Spectacu.la » Evening Sun

Evening Sun. No whitespace for "<p>" in comments and sidebar

(6 posts)

  1. kmb42vt
    Member

    Since there doesn't seem to be an "Evening Sun support" catagory yet, I'm posting this in "Feedback".

    I'm currently using the Evening Sun theme on my personal site; just-thinkin.net . The theme is definitely high quality and beautiful to say the least but one rather glaring problem stood out. There was no white space between paragraphs in either comments or the sidebar (IE: text widgets).
    If someone made a comment or I added a text widget using just html text and this text was separated into two paragraphs, both paragraphs were rendered as one single paragraph. This took away from the over all looks of the theme itself.

    So I added the following to the "typography.css" file:

    p {
margin: 10px 0; padding: 2px;
}

#content p {
margin: 5px 0 10px; padding: 0;
}

#sidebar p {
margin: 5px 0; padding: 0;
 }

    This takes care of the problem nicely. Just wanted you folks to know.

    By the way, I'm assuming all such modifications should go into the "typography.css" file rather than the "style.css" file. If otherwise, please let me know.

    Posted 3 years ago #

  2. James
    Key Master

    Thanks for pointing out the problem. As standard I remove all padding and margins from all elements then add them back where I need them, easiest way to ensure consistency across all browsers. When adding margins back I missed the need for comment and sidebar margins on generated content. That will be added to a new version that I'll make available later today.

    Any modifications you make can be added to typography or style.css. Typography.css is executed first then Style.css is parsed. Any change you make in typography can be superseded by another definition in style.css. So defining 'p {color: red}' in style.css would supersede 'p {color: green}' in typography.css. All additions to style.css must fall under the '@import "typography.css";' line otherwise typography will not be parsed.

    Posted 3 years ago #

  3. James
    Key Master

    Evening sun is now at version 1.0.3. You can download it from the themes section.

    Posted 3 years ago #

  4. kmb42vt
    Member

    Thanks for the reply James and the fast fix.

    I wasn't sure which .css file went first especially since I was fortunate enough that my change wasn't superseded by anything in the "style.css" file making things more confusing. I'll download 1.0.3 and check the "official" changes then. ;)

    I also seem to recall that WP 2.7 has incorporated a "child themes" function where a site owner can add their own custom .css file for any given theme that adds whatever custom styling they wish to an activated theme without changing the actual theme's code in any way. This is supposed to keep all custom styling changes safe when their current theme is updated.

    I'm not a professional coder in anyway but I'm curious to see if that might work for customizations of a theme as well.

    Posted 3 years ago #

  5. clopinettes
    Key Master

    We haven't tried doing much with child themes, although I use it on my own blog having modified a Sandbox child theme.

    The problem, as I see it, is that it's a complex concept to get across to an inexperienced user. Many can grasp the concept of a theme being the visual look of a site, but it's hard to explain that one theme gives the theme a framework, and another gives it the visuals.

    Ultimately we want to make everything as simple and clear as possible - not always easy!

    Posted 3 years ago #

  6. kmb42vt
    Member

    Nope, it's not easy at all. And version 1.3 solved the problem nicely.

    Posted 3 years ago #

RSS feed for this topic

Reply

You must log in to post.